Skip to content

Conversation

@alexander-smolyakov
Copy link
Contributor

@alexander-smolyakov alexander-smolyakov commented Sep 20, 2023

Feature name:

  • ghcr.io/devcontainers/features/python

Description:

This PR aims to resolve the No such file or directory error when commands are executed via the sudo_if function.

Changelog:

  • Removed double quotes to avoid issues with tokenization;
  • Added ability to install the jupyterlab package under root user;
  • Fixed jupyterlab tests;
  • Added new tests to cover the "install under root user" scenario;

Attached related issue:

Checklist:

  • Checked that applied changes work as expected

@alexander-smolyakov alexander-smolyakov requested a review from a team as a code owner September 20, 2023 09:11
This reverts commit 9e62a37.
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, besides that LGTM

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, besides that LGTM

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚢

@samruddhikhandale samruddhikhandale merged commit 0d2fc3a into devcontainers:main Sep 27, 2023
@alexander-smolyakov alexander-smolyakov deleted the python_fix-wrapper-function branch September 28, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants