-
Couldn't load subscription status.
- Fork 514
Use dotnet-install.sh in .NET feature #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samruddhikhandale
merged 38 commits into
devcontainers:main
from
sliekens:dotnet-install-script
Sep 11, 2023
Merged
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
302a34f
Use dotnet-install.sh in .NET feature
sliekens 53b8f30
Use latest.version files
sliekens c035e85
Cleanup runtime args
sliekens d3d149b
Use latest.version files in tests as well
sliekens bfb12d6
Improve tests, remove code duplication
sliekens 00ce410
Add stderr helper
sliekens e2ce463
Validate version inputs
sliekens 5b0b8d9
Use suggested description
sliekens 6f7ddd1
Shorter version description
sliekens cde0ae6
Shorter version description
sliekens fd101aa
Clean up apt lists
sliekens dc7a0be
Verify 7.0 is latest
sliekens 2d0fb73
Fix PATH, add test for .NET global tools
sliekens 5200853
Include a copy of dotnet-install.sh in the Feature
sliekens ad0bf10
Configure useful env variables
sliekens e39d87b
Use stringly typed booleans
sliekens 440d47b
Keep imperative writing style in option hints
sliekens 3d48f77
Update maintainers
sliekens c415add
Move dotnet-install.sh into a vendor directory
sliekens d19b609
Refactor variables
sliekens ea94b44
Amend
sliekens 27b0f44
Amend 2
sliekens 2b2e683
Use default options from devcontainer-feature.json
sliekens 37e14cc
Add back variables
sliekens deb2094
Fix shellchek warning in fetch_latest_sdk_version
sliekens 95028c4
Inline install_version function
sliekens fd39498
Fix ShellCheck warnings
sliekens 8ec9c02
Improve CSV parsing
sliekens 9361e33
Default to latest when configuring an empty version
sliekens f9167de
Add support for runtime-only configurations
sliekens 3ba0f40
Move 'none' check higher up
sliekens 6cdab1e
Deduplicate helper functions, sort into files
sliekens dd3f3ec
Address the user more directly in NOTES
sliekens a5ca01b
Remove unnecessary defaults
sliekens 5b71121
Replace feature -> Feature
sliekens 37c220f
Add update-dotnet-install-script workflow
sliekens 059221f
Apply suggestions from code review
sliekens 8eef025
Don't skip ci for automated script update
sliekens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| name: "Updates vendor 'dotnet-install' script" | ||
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 0 * * 0' # Runs every Sunday at midnight UTC (adjust as needed) | ||
|
|
||
| jobs: | ||
| fetch-latest-dotnet-install: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Run fetch-latest-dotnet-install.sh | ||
| run: src/dotnet/scripts/fetch-latest-dotnet-install.sh | ||
|
|
||
| - name: Create a PR for dotnet-install.sh | ||
| id: push_image_info | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.PAT }} | ||
| run: | | ||
| set -e | ||
| echo "Start." | ||
| # Configure git and Push updates | ||
| git config --global user.email github-actions@github.com | ||
| git config --global user.name github-actions | ||
| git config pull.rebase false | ||
| branch=automated-script-update-$GITHUB_RUN_ID | ||
| git checkout -b $branch | ||
| message='[Updates] Automated vendor 'dotnet-install' script' | ||
| # Add / update and commit | ||
| git add src/dotnet/scripts/vendor/dotnet-install.sh | ||
| git commit -m 'Automated dotnet-install script update [skip ci]' || export NO_UPDATES=true | ||
| # Push | ||
| if [ "$NO_UPDATES" != "true" ] ; then | ||
| git push origin "$branch" | ||
| gh api \ | ||
| --method POST \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| /repos/${GITHUB_REPOSITORY}/pulls \ | ||
| -f title="$message" \ | ||
| -f body="$message" \ | ||
| -f head="$branch" \ | ||
| -f base="$GITHUB_REF_NAME" | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.