Skip to content

Terraform: Add proxy setting (#435) #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 6, 2023
Merged

Terraform: Add proxy setting (#435) #451

merged 11 commits into from
Mar 6, 2023

Conversation

@ksaito1125
Copy link
Contributor

Added proxy settings to features/terraform.

@ksaito1125 ksaito1125 requested a review from a team as a code owner February 13, 2023 07:02
samruddhikhandale
samruddhikhandale reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some comments!

@samruddhikhandale samruddhikhandale linked an issue Feb 14, 2023 that may be closed by this pull request
gpg hangs in proxy environment. #435
Closed
@ksaito1125 ksaito1125 force-pushed the terraform-gpg branch 2 times, most recently from 12024d5 to c9f4276 Compare February 20, 2023 01:14
@ksaito1125
Copy link
Contributor Author

@microsoft-github-policy-service agree

samruddhikhandale
samruddhikhandale requested changes Feb 21, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some additional comments

samruddhikhandale
samruddhikhandale requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, left some more thoughts

ksaito1125
ksaito1125 commented Feb 27, 2023
View reviewed changes
samruddhikhandale
samruddhikhandale reviewed Feb 27, 2023
View reviewed changes
samruddhikhandale
samruddhikhandale requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, besides that looks great!

@ksaito1125 @samruddhikhandale
Update src/terraform/install.sh
c3d87ae 
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
samruddhikhandale
samruddhikhandale approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🚢

@samruddhikhandale samruddhikhandale merged commit 3e6ee96 into devcontainers:main Mar 6, 2023
@ksaito1125 ksaito1125 deleted the terraform-gpg branch March 6, 2023 23:37
@samruddhikhandale samruddhikhandale mentioned this pull request Apr 26, 2023
Closed
@samruddhikhandale samruddhikhandale mentioned this pull request Sep 29, 2023
Closed
@samruddhikhandale samruddhikhandale mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gpg hangs in proxy environment.

2 participants

@ksaito1125 @samruddhikhandale