fix(ruby): accept both "_" and "." tag separators from ruby/ruby#1649
fix(ruby): accept both "_" and "." tag separators from ruby/ruby#1649rhiroe wants to merge 1 commit into
Conversation
4f59d16 to
686a627
Compare
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Hi @rhiroe
Thank you for the contribution. Would you kindly bump the feature version and also add relevant test cases if applicable for this change. Also please check the failing tests.
|
The CI failure is caused by RVM's stable branch not including Ruby 4.x in its known rubies list (it currently tops out at Because I'm not sure what the best path forward is here. A few options come to mind:
Happy to hear any thoughts on which direction makes sense. |
ruby/ruby switched its release tag separator from "_" (e.g. v3_4_9) to "." (e.g. v4.0.4) starting at Ruby 4.0.0. The regex in find_version_from_git_tags only matched the caller-specified separator, so VERSION=latest and ADDITIONAL_VERSIONS resolution silently skipped every 4.x release. Normalize the tag list with `tr "_" "."` before matching and use "." canonically in the regex. The `separator` parameter is no longer consulted for matching, so drop the now-redundant `"_"` argument from the three ruby call sites.
686a627 to
3835dff
Compare
ruby/ruby switched its release tag separator from "_" (e.g. v3_4_9) to "." (e.g. v4.0.4) starting at Ruby 4.0.0. The current regex in find_version_from_git_tags only matches the "_" form, so VERSION=latest and ADDITIONAL_VERSIONS resolution silently skip every 4.x release.
Normalize the tag list with
tr "_" "."before matching and use "." canonically in the regex. Theseparatorparameter is no longer consulted for matching, so drop the now-redundant"_"argument from the three ruby call sites.