Skip to content

Conversation

@byquanton
Copy link
Contributor

No description provided.

@byquanton byquanton requested a review from a team as a code owner September 11, 2025 19:48
scooter-dangle added a commit to rubyforgood/human-essentials that referenced this pull request Sep 14, 2025
See devcontainers/features#1431
See devcontainers/features#1479

We should be able to proceed to debian trixie once the preceding PR is merged.

Sundry extras:
* the rvm-based install of Ruby wasn't sufficient for our subsequent rbenv-based usage of Ruby
* use a 3.4 ruby image
* remove port 3000 from forwarded ports per rails/devcontainer#83 (comment) (and that seemed to help)
Copy link
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @byquanton

Thank you for the contribution. Left one comment for correction.

Copy link
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine. To be further reviewed by maintainer

@AlvaroRausell AlvaroRausell merged commit 8affef0 into devcontainers:main Sep 16, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants