-
Couldn't load subscription status.
- Fork 514
[rust] - Introducing new options to install components #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] - Introducing new options to install components #1404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not the biggest fan of having two flags for one action (installing custom components). I would prefer if we did the following:
create a components option, the default being rust-analyzer,rust-src,rustfmt,clippy` (what currently gets installed), but allowing it to be overridden. This will then allow a user to modify this list if required, without changing default behaviour.
So, as a summary:
- Remove
customComponents - Bump minor version.
Once that is done, I will go through the changes again to give a more detailed review
Hello @AlvaroRausell , Thank you for the review. I have done changes as per the comments provided. Would you kindly review the PR once again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, just one thing you missed
Ref: #1273
Description: This PR aims to solve #1273 to introduce new options
customComponentsandcomponentsto install rust components based on user inputChangelog: The following changes are included.
customComponentsandcomponents(comma separated value for the components to installed ) to install rust components based on user input.customComponentsandcomponentsto install rust components based on user input.Checklist: