Skip to content

Conversation

@Kaniska244
Copy link
Contributor

Ref: #1273

Description: This PR aims to solve #1273 to introduce new options customComponents and components to install rust components based on user input

Changelog: The following changes are included.

  • The installation script is changed to introduce new options customComponents and components (comma separated value for the components to installed ) to install rust components based on user input.
  • Change in devcontainer-feature.json by adding the new options customComponents and components to install rust components based on user input.
  • Test scripts for different components in different combinations
  • The readme file modified with the added information.

Checklist:

  • All checks are passed.

@Kaniska244 Kaniska244 marked this pull request as ready for review July 3, 2025 05:06
@Kaniska244 Kaniska244 requested a review from a team as a code owner July 3, 2025 05:06
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the biggest fan of having two flags for one action (installing custom components). I would prefer if we did the following:
create a components option, the default being rust-analyzer,rust-src,rustfmt,clippy` (what currently gets installed), but allowing it to be overridden. This will then allow a user to modify this list if required, without changing default behaviour.
So, as a summary:

  • Remove customComponents
  • Bump minor version.

Once that is done, I will go through the changes again to give a more detailed review

@Kaniska244
Copy link
Contributor Author

I am not the biggest fan of having two flags for one action (installing custom components). I would prefer if we did the following: create a components option, the default being rust-analyzer,rust-src,rustfmt,clippy` (what currently gets installed), but allowing it to be overridden. This will then allow a user to modify this list if required, without changing default behaviour. So, as a summary:

  • Remove customComponents
  • Bump minor version.

Once that is done, I will go through the changes again to give a more detailed review

Hello @AlvaroRausell ,

Thank you for the review. I have done changes as per the comments provided. Would you kindly review the PR once again.

@Kaniska244 Kaniska244 requested a review from AlvaroRausell July 4, 2025 13:28
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, just one thing you missed

@Kaniska244 Kaniska244 requested a review from AlvaroRausell July 7, 2025 17:23
@AlvaroRausell AlvaroRausell merged commit 805ce77 into devcontainers:main Jul 10, 2025
12 checks passed
@Kaniska244 Kaniska244 deleted the rust-add-component-new branch July 10, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants