-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Handle case where Python version is already installed (#222) #1115
Fix: Handle case where Python version is already installed (#222) #1115
Conversation
gvatsal60
commented
Sep 5, 2024
•
edited
Loading
edited
- Fix: Handle case where Python version is already installed (Python Feature: Fails if the dev container has the requested python version already installed #617)
Hi @samruddhikhandale |
@gvatsal60 The code is intentionally in place. Why would you want to remove |
I am looking into it. Will update the PR soon. |
@samruddhikhandale I have updated the PR. Please have a look... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change make sense to me, let's merge provided the tests are green. Thanks!
@samruddhikhandale Shouldn't this have generated a version update? I thought that any feature change merged to main should have its corresponding version update. NOTE: I just came here trying to check if this PR made the GitHub tags work again but, as the version was not updated, no luck to check... |