Skip to content

[desktop-lite] broken for nonvc versions 1.3.0 and above #1393

@vangeest

Description

@vangeest

Short problem description

desktop-lite doesn't work with noVNC versions above 1.2.0

Observed behaviour for novnc 1.2.0

snippet from devcontainer.json that I use

	"image": "mcr.microsoft.com/devcontainers/universal:latest",
	"features": {
		"ghcr.io/devcontainers/features/desktop-lite:latest": {
			"version": "latest",
			"noVncVersion": "1.2.0", 
			"password": "secret",
			"webPort": "6080",
			"vncPort": "5901"
		}
  1. When the container has booted, you see a port opened in vs-code.
  2. Clicking on the link from port 6080 will open novnc and user can connect to the vnc-server

Observed behaviour for novnc 1.3.0 and later

change 1.2.0 in the above devcontainer configuration to anything else (i tried 1.4.0 and 1.6.0)

  1. When the container has booted, you see no port opened in vs-code.

Expected behaviour

versions 1.3.0 and above are expected to work (start novnc) just like 1.2.0

Probable cause

The desktop-lite install.sh depends on novnc*/utils/launch.sh

see https://github.com/devcontainers/features/blob/main/src/desktop-lite/install.sh

launch.sh is not available anymore as of novnc versions 1.3.0

see
https://github.com/novnc/noVNC/releases
The novnc_proxy command (earlier launch.sh) is now able to interface better towards Websockify and now has it's own man page.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions