Skip to content

Add Integrated Circuit Design Devcontainer Template #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2023
Merged

Add Integrated Circuit Design Devcontainer Template #185

merged 2 commits into from
Apr 11, 2023

Conversation

curtisma
Copy link
Contributor

@curtisma curtisma commented Apr 9, 2023

Add the Viper open-source integrated circuit dev container template.

@curtisma curtisma requested a review from a team as a code owner April 9, 2023 18:13
@curtisma curtisma changed the title Add Integrated Circuit design template Add Integrated Circuit Design Devcontainer Template Apr 9, 2023
samruddhikhandale
samruddhikhandale reviewed Apr 10, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @curtisma can you help resolve the merge conflict?

@curtisma
Copy link
Contributor Author

curtisma commented Apr 10, 2023 •
edited
Loading

Thanks! @curtisma can you help resolve the merge conflict?

Yeah, I will do that this evening.
Thanks!

@curtisma
Copy link
Contributor Author

curtisma commented Apr 11, 2023 •
edited
Loading

Ok, the merge conflict is fixed to include both items.
It should be good to go @samruddhikhandale.

samruddhikhandale
samruddhikhandale approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ⚡

@samruddhikhandale samruddhikhandale merged commit f7e4d20 into devcontainers:gh-pages Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curtisma @samruddhikhandale