Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for disallowed features #521

Merged
merged 7 commits into from
May 19, 2023
Merged

Check for disallowed features #521

merged 7 commits into from
May 19, 2023

Conversation

chrmarti
Copy link
Contributor

No description provided.

@chrmarti chrmarti marked this pull request as ready for review May 16, 2023 15:04
@chrmarti chrmarti requested a review from a team as a code owner May 16, 2023 15:04
joshspicer
joshspicer previously approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided a couple suggestions, but nothing that I feel too strongly about :)

@chrmarti @joshspicer
Update src/spec-configuration/controlManifest.ts
14bee1e 
Co-authored-by: Josh Spicer <joshspicer@github.com>
chrmarti and others added 5 commits May 17, 2023 09:50
@chrmarti
Copy link
Contributor Author

@joshspicer Thanks, addressed your feedback. Please re-review and reapprove.

@chrmarti chrmarti merged commit d1628d3 into main May 19, 2023
@chrmarti chrmarti deleted the chrmarti/valuable-locust branch May 19, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrmarti @joshspicer