Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature|Template publishing] Require name property #447

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Mar 14, 2023

While we currently don't require this property in the spec, many of the downstream tools currently rely on this property. For Features published from here forward, we should ensure there is a name property.

Given that the starter template repo and the 100% of the Features in the public index have a name property - this property is already de facto required.

@joshspicer joshspicer requested a review from a team as a code owner March 14, 2023 21:58
@joshspicer joshspicer merged commit e3d12b3 into main Mar 15, 2023
@joshspicer joshspicer deleted the joshspicer/stricter-feature-publishing branch March 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants