Skip to content

features test... command: Copy entire test folder on test execution and improve CLI command usage. #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 7, 2022

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer commented Nov 2, 2022

Tracking: #139

Some changes/improvements to the devcontainers features test command.

  • Deprecates the required positional in favor of a flag. This fixes the bug with ordering options lets the command be run parameterless for all defaults
  • Now copies entire /test folder over to each test run, so tests (scenarios, etc..) can share scripts between runs
  • Avoids outputting test command-related output to standard error.

@joshspicer joshspicer marked this pull request as ready for review November 6, 2022 20:08
@joshspicer joshspicer requested a review from a team as a code owner November 6, 2022 20:08
chrmarti
chrmarti previously approved these changes Nov 7, 2022
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion.

@joshspicer joshspicer changed the title improve the features test... command features test... command: Copy entire test folder on test execution and improve CLI command usage. Nov 7, 2022
@joshspicer joshspicer merged commit 17ca5f9 into main Nov 7, 2022
@joshspicer joshspicer deleted the joshspicer/test-cmd-improvements branch November 7, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants