Skip to content

Add support for multiple tags#183

Merged
stuartleeks merged 13 commits intodevcontainers:mainfrom
natescherer:feature/multiple-tags
Feb 7, 2023
Merged

Add support for multiple tags#183
stuartleeks merged 13 commits intodevcontainers:mainfrom
natescherer:feature/multiple-tags

Conversation

@natescherer
Copy link
Contributor

Hello!
This PR adds support for pushing multiple tags via the existing imageTag input; you can now provide a comma-separated list of tags.

I tested with the following scenarios, both for the GH Action and AzDO Task:

  • Single Arch, Multi Tag
  • Single Arch, Single Tag
  • Single Arch, No Tag 'latest' fallback
  • Multi Arch, Multi Tag
  • Multi Arch, Single Tag
  • Multi Arch, No Tag 'latest' fallback

This will close #151.

Let me know if you have any questions or would like me to make any changes!

@natescherer natescherer requested review from a team and stuartleeks as code owners November 18, 2022 23:55
@stuartleeks
Copy link
Collaborator

Thanks @natescherer! I've had a quick scan of the changes and it looks good so far.

Could you update the docs (root README for GitHub action and under azdo-task for the Azure DevOps task)?

It would also be really good to add some tests that validate that this is working (and keeps working).

@stuartleeks
Copy link
Collaborator

Apologies for the delay replying - thanks for updating the docs @natescherer.

Do you have any thoughts about how we could approach automated testing of the multi-tag support?

Copy link
Collaborator

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, LGTM otherwise, thanks!

@natescherer
Copy link
Contributor Author

Apologies for the delay replying - thanks for updating the docs @natescherer.

Do you have any thoughts about how we could approach automated testing of the multi-tag support?

No worries on the delay, December and January are extremely busy for me and I haven't had much time for OSS. Here's a test I developed in my own repo that seems to work; hopefully I substituted in the right values for devcontainers/ci.

chrmarti
chrmarti previously approved these changes Feb 6, 2023
@stuartleeks
Copy link
Collaborator

/test 1f0dea7

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/devcontainers/ci/actions/runs/4114934939

(in response to this comment from @stuartleeks)

Copy link
Collaborator

@stuartleeks stuartleeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@stuartleeks stuartleeks merged commit c5e74b5 into devcontainers:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow multiple architectures, image tags for image builds

3 participants