Skip to content

GitHub URL from context #204

Open
Open
GitHub URL from context#204
Labels
enhancementNew feature or request

Description

@lure8225
lure8225
opened on Dec 6, 2023

Hi, for using this in a GitHub enterprise context it would be necessary to get the base url from the context instead of hardcoding it to github.com

action/src/generateDocs.ts

Line 120 in 5002ae5

urlToConfig = `https://github.com/${srcInfo.owner}/${srcInfo.repo}/blob/main/${basePathTrimmed}/${f}/${metadataFile}`;

I think it should be available from here

https://github.com/actions/toolkit/blob/04945c6048e796f86b5c4cf1965faa378af67480/packages/github/src/context.ts#L23C5-L23C5

Sorry that I currently am not able to directly do a PR for that.

Activity

  1. joshspicer
    added
    enhancementNew feature or request
    on Dec 6, 2023

  2. joshspicer commented on Dec 6, 2023

    @joshspicer
    joshspicer
    on Dec 6, 2023
    Contributor

    This generated URL is pointing to documentation for a dev container Feature, which themselves are hosted in container registries. I want to understand the goal here better - is your team publishing Features to a container registry with the source code in your private GitHub enterprise instance?

    cc/ Eljo George (@eljog)

  3. lure8225 commented on Dec 7, 2023

    @lure8225
    lure8225
    on Dec 7, 2023
    Author

    Exactly, we are publishing features to a private OCI registry from a GHE instance. These features are then used for building images/devcontainers which our internal workspaces are using

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions