Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Danger for common CI/code review chores #280

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

yawboakye
Copy link
Member

I only added the gem to the test group since it runs in CI since obviously we shouldn't load it in production. I also created the Dangerfile.

thedumbtechguy
thedumbtechguy previously approved these changes Jun 22, 2020
Copy link
Contributor

@thedumbtechguy thedumbtechguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending conflict resolution

also move gems around and add comment where i know the purpose of gem
and it may not be obvious.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants