upgrade #51
upgrade #51
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive upgrade of dependencies, Go version, and linter configuration. However, it contains several critical issues that need to be addressed before merging.
Key Changes:
- Go version upgrade (1.23.4 -> 1.25.5) and dependency updates
- Major restructuring of golangci-lint configuration
- Refactoring of error message strings to constants in githubwebhookhandler.go
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version and dependency versions, removes some indirect dependencies |
| go.sum | Updates checksums for all upgraded dependencies |
| .golangci.yml | Restructures linter configuration from v1 to v2 format with simplified settings |
| githubwebhookhandler.go | Extracts hardcoded error message strings into named constants |
| .gitignore | Adds .claude/ directory to ignored files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: time-naming | ||
| - name: unchecked-type-assertion | ||
| arguments: | ||
| - accept-ignored-assertion-result: true |
There was a problem hiding this comment.
The argument key changed from 'acceptIgnoredAssertionResult' (camelCase) to 'accept-ignored-assertion-result' (kebab-case). Verify this is compatible with your golangci-lint and revive versions, as the configuration format may differ between versions.
| - accept-ignored-assertion-result: true | |
| - acceptIgnoredAssertionResult: true |
| formatters: | ||
| enable: | ||
| - gofmt | ||
| - gofumpt | ||
| - goimports | ||
| - golines | ||
| settings: | ||
| golines: | ||
| max-len: 120 No newline at end of file |
There was a problem hiding this comment.
The 'formatters' section is not a valid top-level key in golangci-lint configuration. Formatters like gofmt, gofumpt, goimports, and golines should be configured as linters, not formatters. They should be added to the 'linters.enable' list instead. This configuration section will be ignored.
| - allow-regex: "^_" | ||
| - name: unused-receiver | ||
| arguments: | ||
| - allow-regex: "^_" |
There was a problem hiding this comment.
The argument key has changed from 'allowRegex' to 'allow-regex' (kebab-case). Verify this is compatible with your golangci-lint and revive versions, as some versions may expect camelCase ('allowRegex') for this configuration parameter.
| - allow-regex: "^_" | |
| - name: unused-receiver | |
| arguments: | |
| - allow-regex: "^_" | |
| - allowRegex: "^_" | |
| - name: unused-receiver | |
| arguments: | |
| - allowRegex: "^_" |
| - name: var-naming | ||
| arguments: | ||
| - ["ID"] # AllowList | ||
| - ["VM"] # DenyList | ||
| - - skip-initialism-name-checks: true | ||
| upper-case-const: true | ||
| skip-package-name-checks: true | ||
| skip-package-name-collision-with-go-std: true | ||
| extra-bad-package-names: | ||
| - helpers | ||
| - utils | ||
| - tools | ||
| - models |
There was a problem hiding this comment.
The var-naming rule arguments structure has changed significantly. The new nested configuration under the third array element uses kebab-case keys (e.g., 'skip-initialism-name-checks', 'upper-case-const') instead of the original camelCase ('upperCaseConst'). Additionally, several new fields have been added. Verify that these kebab-case parameter names and the new nested structure are compatible with your version of revive, as different versions may expect different formats.
| settings: | ||
| govet: | ||
| enable: | ||
| - assign | ||
| - appends | ||
| - bools | ||
| - defers | ||
| - shadow | ||
| - unmarshal | ||
| - waitgroup | ||
| - lostcancel | ||
| - slog | ||
| - unreachable | ||
| errcheck: | ||
| check-type-assertions: true | ||
| wrapcheck: | ||
| ignore-package-globs: | ||
| - encoding/* | ||
| - github.com/pkg/* | ||
| revive: |
There was a problem hiding this comment.
The linters configuration structure has changed from 'linters-settings' to 'linters.settings'. According to golangci-lint v2 configuration format, linter settings should be at the top level under 'linters-settings', not nested under 'linters.settings'. The correct structure should be:
linters-settings:
govet:
enable: [...]
rather than:
linters:
settings:
govet:
enable: [...]
This misplacement will likely cause the linter configuration to be ignored.
| errcheck: | ||
| check-type-assertions: true | ||
| wrapcheck: | ||
| ignore-package-globs: |
There was a problem hiding this comment.
The configuration key has changed from 'ignorePackageGlobs' to 'ignore-package-globs' (kebab-case). While this follows YAML naming conventions better, verify this is compatible with your golangci-lint version. Some versions expect camelCase for this setting.
| ignore-package-globs: | |
| ignorePackageGlobs: |
| - allow-regex: "^_" | ||
| - name: unused-receiver | ||
| arguments: | ||
| - allow-regex: "^_" |
There was a problem hiding this comment.
The argument key has changed from 'allowRegex' to 'allow-regex' (kebab-case). Verify this is compatible with your golangci-lint and revive versions, as some versions may expect camelCase ('allowRegex') for this configuration parameter.
| - allow-regex: "^_" | |
| - name: unused-receiver | |
| arguments: | |
| - allow-regex: "^_" | |
| - allowRegex: "^_" | |
| - name: unused-receiver | |
| arguments: | |
| - allowRegex: "^_" |
| - name: early-return | ||
| arguments: | ||
| - "preserve-scope" | ||
| - "allow-jump" |
There was a problem hiding this comment.
The argument format has changed from "preserveScope" to "preserve-scope" and added a new "allow-jump" argument. Verify these are valid arguments for the early-return rule in your version of revive. The original "preserveScope" argument may not be recognized in kebab-case format.
| - "allow-jump" |
No description provided.