Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ng-bank-parser][ReadMe] Fix Typos #8

Merged
merged 4 commits into from
Sep 5, 2015
Merged

[ng-bank-parser][ReadMe] Fix Typos #8

merged 4 commits into from
Sep 5, 2015

Conversation

unicodeveloper
Copy link
Contributor

No description provided.

@fathermerry
Copy link
Contributor

Hey, thanks for this. The use of bank_key is intentional. That's cause it's different from bank_name. They key is the slug we use to identify the banks. So while for example the bank_name is Guaranty Trust Bank, the bank_key is GTB

@unicodeveloper
Copy link
Contributor Author

I saw that, but after the parameters i discovered that you used bank_name while describing the key of the bank that will be passed as a parameter. Am i right?. Then i saw bank_name as a key appearing in the result set. I think i should have just replaced the bank_name with bank_key in the description.

@fathermerry
Copy link
Contributor

Absolutely. All the parameters should be bank_key. The bank_name in the result is the actually full bank name. Kindly update your pull request so I can merge. Thanks!

@unicodeveloper
Copy link
Contributor Author

Check it out. I just updated it, Please let me know if there's something not rightly placed or positioned.

@fathermerry
Copy link
Contributor

One last thing. In the API section, the parameter is bank_key

@unicodeveloper
Copy link
Contributor Author

Aha!.Totally missed that, thanks for pointing it out. Fixed!

fathermerry added a commit that referenced this pull request Sep 5, 2015
[ng-bank-parser][ReadMe] Fix Typos
@fathermerry fathermerry merged commit 59819c4 into devcenter-square:dev Sep 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants