change status codes

devcenter-square · Sep 26, 2015 · a15de4b · a15de4b
1 parent 793f32b
commit a15de4b
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 14 deletions.
diff --git a/README.md b/README.md
@@ -39,7 +39,7 @@ result = NgBankParser::Router.parse(bank_key, file_path, password)
 
 ```ruby
 result = {
-    status: 1,
+    status: 200,
     data: {
         bank_name: the_bank_name,
         account_number: the_account_number,
@@ -55,7 +55,7 @@ result = {
 
 ```ruby
 result = {
-    status: 0,
+    status: 400,
     message: "RELEVANT ERROR MESSAGE"
 }
 ```

diff --git a/lib/ng-bank-parser/parsers/accessbank-pdf-parser/helpers.rb b/lib/ng-bank-parser/parsers/accessbank-pdf-parser/helpers.rb
@@ -114,11 +114,11 @@ def get_transactions(pdf_array)
 
 
   def error(msg)
-    { status: 0, message: msg }
+    { status: 400, message: msg }
   end
 
   def success(data)
-    { status: 1, data: data }
+    { status: 200, data: data }
   end
 
 

diff --git a/lib/ng-bank-parser/parsers/firstbank-pdf-parser/helpers.rb b/lib/ng-bank-parser/parsers/firstbank-pdf-parser/helpers.rb
@@ -157,15 +157,15 @@ def is_row_invalid? row
 
 		def error_message msg
 			return {
-					status: 0,
+					status: 400,
 					message: msg
 				}
 		end
 
 
 		def send_response data
 			return {
-					status: 1,
+					status: 200,
 					data: data
 				}
 		end

diff --git a/lib/ng-bank-parser/parsers/gtb-excel-parser.rb b/lib/ng-bank-parser/parsers/gtb-excel-parser.rb
@@ -50,14 +50,14 @@ def xls_parse(file)
 
 			def error_message(text)
 				return { 
-					status: 0, 
+					status: 400,
 					message: text
 				}
 			end
 
 			def send_response(data)
 				return {
-					status: 1,
+					status: 200,
 					data: data
 				}
 			end

diff --git a/lib/ng-bank-parser/parsers/hb-pdf-parser/hb_constants.rb b/lib/ng-bank-parser/parsers/hb-pdf-parser/hb_constants.rb
@@ -2,8 +2,8 @@ module NgBankParser
   module HbConstants
     ACCEPTED_FORMATS = ['.pdf']
 
-    INVALID_ACCOUNT_STATUS = 0
-    VALID_ACCOUNT_STATUS = 1
+    INVALID_ACCOUNT_STATUS = 400
+    VALID_ACCOUNT_STATUS = 200
 
     SECOND_PAGE_INDEX = 1
     DURATION_DATE_LINE_INDEX = 3

diff --git a/lib/ng-bank-parser/parsers/uba-pdf-parser.rb b/lib/ng-bank-parser/parsers/uba-pdf-parser.rb
@@ -87,7 +87,7 @@ def set_dates
 
       def return_payload
         return {
-            status: 1,
+            status: 200,
             data: {
                 bank_name: @bank_name,
                 account_number: @account_number,
@@ -101,7 +101,7 @@ def return_payload
 
       def invalid_file
         return {
-            status: 0, message: INVALID_FILE_STRING
+            status: 400, message: INVALID_FILE_STRING
         }
       end
 

diff --git a/spec/banks_spec.rb b/spec/banks_spec.rb
@@ -65,7 +65,7 @@
 				response = class_object.parse(invalid_file_path)
 
 				it "returns proper response" do
-					expect(response[:status]).to eq(0);
+					expect(response[:status]).to eq(400);
 				end
 			end
 
@@ -74,7 +74,7 @@
 				response = class_object.parse(valid_file_path, password)
 
 				it "parses statement correctly" do
-					expect(response[:status]).to eq(1)
+					expect(response[:status]).to eq(200)
 					expect(response[:data]).to match({
 						:bank_name => an_instance_of(String),
 						:account_number => an_instance_of(String),