Updates to first bank parser

lib/ng-bank-parser/banks.rb

@@ -23,7 +23,7 @@ class Banks
 			name: "First Bank",
 			parsers: [{
 				format: "pdf",
-				valid: "lib/ng-bank-parser/fixtures/firstbank-pdf-valid.pdf",
+				valid: "http://helloworld.ng/firstbank.pdf", #{}"lib/ng-bank-parser/fixtures/firstbank-pdf-valid.pdf",
 				fixture_password: 19856,
 				invalid: "lib/ng-bank-parser/fixtures/firstbank-pdf-invalid.pdf",
 				extensions: ["pdf"]

lib/ng-bank-parser/parsers/firstbank-pdf-parser.rb

@@ -14,7 +14,9 @@ def self.parse(path, password = nil)
 				return error_message 'Invalid file format'
 			end
 
-			if has_encryption? path
+			file = open(path)
+
+			if has_encryption? file
 				if password
 					unless get_unlocked_pdf? path, password
 						return error_message 'Password supplied for decryption is invalid.'
@@ -41,10 +43,8 @@ def self.parse(path, password = nil)
 			else
 				return error_message 'Could not find any transactions'
 			end
-
 		end
 
-
 		private
 
 		def self.extract_transactions(jagged_array = [[]])

lib/ng-bank-parser/parsers/firstbank-pdf-parser/helpers.rb

@@ -17,25 +17,31 @@ module FirstbankPdfHelpers
 		@@from_date = nil
 		@@to_date = nil
 
-		def has_encryption? path
+		def has_encryption? file
 			begin
-				@@pdf_reader = PDF::Reader.new(path)
+				@@pdf_reader = PDF::Reader.new(file)
 				false
 			rescue PDF::Reader::EncryptedPDFError
 				true
 			end
 		end
 
 		def get_unlocked_pdf? path, password
-			response = PDFUnlocker.new(File.new(path), password).unlocked_pdf
+			file = open(path)
+			# file = File.new("lib/ng-bank-parser/fixtures/firstbank-pdf-valid.pdf")
+			response = PDFUnlocker.new(file, password).unlocked_pdf
 			return false unless response
 			if response.include? 'Unlock Failed'
 				return false
 			else
 				pseudo_file = StringIO.new
 				pseudo_file.write(response)
-				@@pdf_reader = PDF::Reader.new(pseudo_file)
-				return true
+				begin
+					@@pdf_reader = PDF::Reader.new(pseudo_file)
+					return true
+				rescue
+					return false					
+				end
 			end
 		end
 

lib/ng-bank-parser/pdf-unlocker.rb

@@ -6,11 +6,11 @@ class PDFUnlocker
 		base_uri 'http://pdf-unlocker.herokuapp.com'
 
 		def initialize(file, password)
+			puts file
 			@pdf = file
 			@password = password
 		end
 
-
 		def unlocked_pdf
 			options = { :pdf => @pdf, :password => @password }
 			begin