Skip to content

chore(deps): bump google.golang.org/protobuf from 1.36.12-0.20260120151049-f2248ac996af to 1.36.12 - #6678

Merged
devantler merged 2 commits into
mainfrom
dependabot/go_modules/google.golang.org/protobuf-1.36.12
Aug 26, 2026
Merged

chore(deps): bump google.golang.org/protobuf from 1.36.12-0.20260120151049-f2248ac996af to 1.36.12#6678
devantler merged 2 commits into
mainfrom
dependabot/go_modules/google.golang.org/protobuf-1.36.12

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 26, 2026

Copy link
Copy Markdown
Contributor

Bumps google.golang.org/protobuf from 1.36.12-0.20260120151049-f2248ac996af to 1.36.12.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps google.golang.org/protobuf from 1.36.12-0.20260120151049-f2248ac996af to 1.36.12.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-version: 1.36.12
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@ksail-bot
ksail-bot Bot enabled auto-merge (squash) August 26, 2026 17:20
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

MegaLinter analysis: Success

✅ Linters with no issues

actionlint, bash-exec, git_diff, hadolint, jscpd, jsonlint, lychee, markdown-table-formatter, markdownlint, prettier, prettier, shellcheck, shfmt, stylelint, syft, trivy-sbom, trufflehog, v8r, v8r, yamllint

Notices

⚠️ Your configuration references items that have been removed from MegaLinter and are ignored: REPOSITORY_GITLEAKS. See Removed linters to find their replacements.

See detailed reports in MegaLinter artifacts

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@devantler
devantler marked this pull request as draft August 26, 2026 18:41
auto-merge was automatically disabled August 26, 2026 18:41

Pull request was converted to draft

The desktop module consumes the root module through a local replace
directive, so a root-only dependency bump leaves desktop/go.mod still
requiring the superseded pseudo-version. go list -deps ./... in desktop then
refuses with "updates to go.mod needed", which is what failed the Test,
Build, Coverage and Verify Desktop Module Tidy checks.

Runs go mod tidy in desktop/ — one indirect requirement and its two go.sum
lines. Dependabot targets a single module, so it cannot make this edit itself.
@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Adapted at d85e4f9e — two distinct root causes, only one of them real

This PR could not reach merge on its own, so I took it over per the dependency-automation
intervention rule. Converted to draft first (which also cleared auto-merge) before pushing.

1. The real blocker — desktop/ was left inconsistent

desktop/go.mod consumes the root module through replace github.com/devantler-tech/ksail/v7 => ../,
so a root-only bump leaves desktop still requiring the superseded
v1.36.12-0.20260120151049-f2248ac996af. go list -deps ./... in desktop then refuses with
updates to go.mod needed, which is what failed 🧪 Test
(TestClaircoreLinkedPackagesStayInert/desktop), and with it 🏗️ Build, 📊 Code Coverage and
🧩 Verify Desktop Module Tidy.

Dependabot targets one module per update, so it structurally cannot make this edit.

Fix: go mod tidy in desktop/ — one indirect requirement plus its two go.sum lines.

Verified behaviourally, not just by build: running the exact command the failing test runs,
against the pre-tidy files and then the tidied ones —

files go list -deps ./... in desktop updates to go.mod needed
pre-tidy (this PR's old head) exit 1 present
tidied exit 0 absent

2. A separate transient I ruled out rather than re-ran blind

🧩 Verify Desktop Module Tidy also reported, at 17:26:52Z, a checksum mismatch on the unrelated
github.com/anchore/go-macholibre@v0.1.0:

This download does NOT match an earlier download recorded in go.sum.

That reads alarming, so it is worth stating what it was not. The authoritative Go checksum database
records h1:qHbdusBZNcZM/uuKf1Psa9xxAFSoyRTps8GW9gpJgsg= for that version, which is exactly what
this repository's go.sum already contains — it was the downloaded bytes that differed. So the
repository is correct, the module was not re-published, and Go's tamper-evidence did its job on a
corrupt proxy response. It landed inside the GitHub Actions incident window (opened 15:11:58Z), which
is the most likely explanation. No change is warranted for it; it should not recur on this head.

Both causes had to be separated before acting: re-running would not have fixed the first, and editing
go.sum would have been the wrong response to the second.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

This started as a Dependabot bump but carries an agent-authored adaptation commit, which restores the normal semantic-review gate rather than the untouched-bot-head exemption. The adaptation propagates the same google.golang.org/protobuf 1.36.12 version into the desktop/ module so the two modules do not diverge; the diff is four files and nothing but the version and its checksums. CI is green at this head (56 success, 16 skipped, 0 failing).

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

@devantler I will review the changes at the requested head.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fbc4954a-8ab4-4e95-afa5-3f5a7021e27f

📥 Commits

Reviewing files that changed from the base of the PR and between 128710e and d85e4f9.

⛔ Files ignored due to path filters (2)
  • desktop/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • desktop/go.mod
  • go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

📜 Recent review details
🔇 Additional comments (2)
go.mod (1)

108-108: LGTM!

desktop/go.mod (1)

796-796: LGTM!


📝 Walkthrough

Walkthrough

Updated the google.golang.org/protobuf dependency from a pseudo-version to the released v1.36.12 version in go.mod and desktop/go.mod.

Merge Risk: ⚪ Minimal · up to d85e4

This is a localized dependency metadata update with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the protobuf dependency update and includes both the previous pseudo-version and the released version.
Description check ✅ Passed The description directly explains the protobuf dependency update and provides relevant Dependabot context.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devantler

Copy link
Copy Markdown
Contributor

🤖 Generated by the Agentic Engineer

Readiness at d85e4f9eb4b4cc59b58213b9037e8dc973e94c8f.

Programmatically tested — 58 successful checks, 16 skipped, 0 failing, 0 pending.

Reviewed — CodeRabbit green at this head: its auto-generated summary naming the full head was refreshed at 20:13:17Z, after this round's request marker at 20:10:22Z, carrying no rate-limit or service marker; the head's CodeRabbit status reads Review completed. No finding sections in that review — the only section present is the excluded 🔇 Additional comments, whose two entries are both LGTM! on the two go.mod version lines. Zero unresolved threads, zero non-thread findings.

Tried and evaluated as a user — this bump has a real runtime surface, and CI exercises it rather than only compiling it: the head ran the full System Test (Docker) matrix, which provisions actual clusters across Talos, K3s, Vanilla, VCluster and KWOK with Cilium/Calico and Flux/ArgoCD, using the binary built against protobuf 1.36.12 in both modules. All passed. I read that matrix as the observation, not the build step.

Note on ownership: this PR was opened by Dependabot, but its head is an agent-authored adaptation propagating the same version into the desktop/ module so the two Go modules do not diverge. That revokes the untouched-bot-head no-review exemption and restores the normal semantic-review gate, which is why a review was requested rather than relying on auto-merge. Promoting and merging directly (--squash --match-head-commit); this repository has no merge queue.

@devantler
devantler marked this pull request as ready for review August 26, 2026 20:17
@devantler
devantler merged commit 2c528c0 into main Aug 26, 2026
75 checks passed
@devantler
devantler deleted the dependabot/go_modules/google.golang.org/protobuf-1.36.12 branch August 26, 2026 20:18
@github-project-automation github-project-automation Bot moved this from 🫴 Ready to ✅ Done in 🌊 Project Board Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant