-
-
Notifications
You must be signed in to change notification settings - Fork 5
Daily Test Coverage Improver - Fix Go Setup in Coverage Steps #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily Test Coverage Improver - Fix Go Setup in Coverage Steps #1921
Conversation
The coverage-steps action was attempting to use 'go' without first setting up the Go environment using actions/setup-go. This caused the action to fail when running in GitHub Actions workflows. Changes: - Replace shell-based Go version check with actions/setup-go@v6 - Add go-version-file parameter to use version from go.mod - Enable caching for faster subsequent runs - Renumber steps to maintain sequential order This ensures Go is properly installed and available before running any Go commands in the coverage collection workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a critical bug in the Daily Test Coverage Improver workflow where the coverage-steps composite action was attempting to use the go command without first setting up the Go environment, causing "go: command not found" errors.
Changes:
- Added proper Go setup using
actions/setup-go@v6with go.mod version detection - Split the setup into two steps: Setup Go (step 1) and Verify Go setup (step 2)
- Renumbered all subsequent steps (3-9) to maintain sequential order
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@devantler I've opened a new pull request, #1922, to work on those changes. Once the pull request is ready, I'll request review from you. |
…he parameter (#1922) * Initial plan * fix: Update setup-go version comment and remove cache parameter - Change version comment from v6 to v6.2.0 to match codebase convention - Remove cache: true parameter (caching enabled by default) Co-authored-by: devantler <26203420+devantler@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: devantler <26203420+devantler@users.noreply.github.com>
✅
|
* fix: Add proper Go setup to coverage-steps action The coverage-steps action was attempting to use 'go' without first setting up the Go environment using actions/setup-go. This caused the action to fail when running in GitHub Actions workflows. Changes: - Replace shell-based Go version check with actions/setup-go@v6 - Add go-version-file parameter to use version from go.mod - Enable caching for faster subsequent runs - Renumber steps to maintain sequential order This ensures Go is properly installed and available before running any Go commands in the coverage collection workflow. * Apply review feedback: update setup-go version comment and remove cache parameter (#1922) * Initial plan * fix: Update setup-go version comment and remove cache parameter - Change version comment from v6 to v6.2.0 to match codebase convention - Remove cache: true parameter (caching enabled by default) Co-authored-by: devantler <26203420+devantler@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: devantler <26203420+devantler@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: devantler <26203420+devantler@users.noreply.github.com>

Problem
The coverage-steps action (
.github/actions/daily-test-improver/coverage-steps/action.yml) was attempting to use thegocommand without first setting up the Go environment. This caused the action to fail when running in GitHub Actions workflows with the errorgo: command not found.Solution
This PR fixes the issue by:
go versioncheck withactions/setup-go@v6go.mod(currently 1.25.4)Changes Made
Impact
This fix enables the Daily Test Coverage Improver workflow to:
coverage.txtandcoverage.html)Validation
The fix follows the same pattern used in existing CI workflows:
.github/workflows/coverage.yaml.github/workflows/system-tests.yamlBoth use
actions/setup-go@v6withgo-version-file: go.mod.Next Steps
Once this PR is merged, the next workflow run will be able to:
Related: This fix is required for Phase 3 of the Daily Test Coverage Improver workflow as documented in discussion #1826.