fix: improve release workflow to publish only after release PR merge #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devakone
force-pushed
the
fix-release-workflow
branch
from
629772f to
4c14c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: improve release workflow
This PR improves the CI/CD workflow to ensure that npm packages are only published after the release-please PR is merged.
Changes
Split the release job into two separate jobs:
create-release: Handles creating the release PR with release-pleasepublish-npm: Only runs after a release is actually createdFixed the conditional logic to only publish when release-please creates a release
releases_createdoutput parameter from release-pleaseUpdated the token for release-please to use GH_TOKEN
Testing
This change has been tested by reviewing the logic against the release-please documentation.
After merging: