Support SCRAM-SHA-256 password hashing on 10+ #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
reviewed
Feb 4, 2019
There was a problem hiding this comment.
@kravietz Thank you for this PR. Great work. I added some ideas for improvement .
| end | ||
| describe postgres_conf(POSTGRES_CONF_PATH) do | ||
| its('password_encryption') { should eq 'on' } | ||
| describe command('psql -V') do |
There was a problem hiding this comment.
Can we make this a ruby function? e.g. def pg_version() that returns 9 or 10 as the version? Then the test could look much simpler:
expected_passwd = /^md5\S*$/
expected_password_encryption = 'on'
if pg_version() == 10
expected_passwd = /^scram-sha-256\S*$/
expected_password_encryption = 'scram-sha-256'
end
describe postgres_session(USER, PASSWORD).query('SELECT passwd FROM pg_shadow;') do
its('output') { should match(expected_passwd) }
end
describe postgres_conf(POSTGRES_CONF_PATH) do
its('password_encryption') { should eq expected_password_encryption }
end
There was a problem hiding this comment.
@chris-rock I'm afraid my knowledge of Ruby is asymptotic to zero :)
|
@kravietz Can you fix the DCO, I'll work on top of your PR to add the changes then |
Signed-off-by: Pawel Krawczyk <pawel.krawczyk@hush.com>
|
Thanks @chris-rock sign-off done! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #24
Please review this for syntax correctness as I don't have plenty of experience with this.