Skip to content
This repository was archived by the owner on Dec 26, 2020. It is now read-only.

Do not use bash to get ssh version #266

Merged
merged 2 commits into from
Feb 13, 2020
Merged

Do not use bash to get ssh version #266

merged 2 commits into from
Feb 13, 2020

Conversation

@kljensen
Copy link
Contributor

@kljensen kljensen commented Feb 10, 2020

Closes #265

@kljensen
Do not use bash to get ssh version
ed9ec7c 
Signed-off-by: Kyle L. Jensen <kljensen@gmail.com>
rndmh3ro
rndmh3ro reviewed Feb 12, 2020
View reviewed changes
@rndmh3ro
Copy link
Member

rndmh3ro commented Feb 12, 2020

Looks great! Especially the set_fact is a good idea, increases overall readability!

I only got one minor addition. If you add this, I'll merge this pr.

@kljensen
Add changed_when and check_mode options to ssh version check
f6370ca 
Signed-off-by: Kyle L. Jensen <kljensen@gmail.com>
@kljensen
Copy link
Contributor Author

kljensen commented Feb 13, 2020

Thanks @rndmh3ro - I added those options

@rndmh3ro
Copy link
Member

rndmh3ro commented Feb 13, 2020

Thank you!

@rndmh3ro rndmh3ro merged commit ed3748f into dev-sec:master Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rndmh3ro rndmh3ro rndmh3ro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dependency on bash

2 participants

@kljensen @rndmh3ro