Skip to content
This repository was archived by the owner on Dec 26, 2020. It is now read-only.

Conversation

@MatthiasLohr
Copy link
Contributor

Pull Request for #175.

Signed-off-by: Matthias Lohr <mail@mlohr.com>
@rndmh3ro
Copy link
Member

Looks good on first glance. :)
Can you add the option for testing here: https://github.com/dev-sec/ansible-ssh-hardening/blob/master/tests/default_custom.yml ?

Signed-off-by: Matthias Lohr <mail@mlohr.com>
@MatthiasLohr
Copy link
Contributor Author

So... how to fix the testcase? I think it's not expecting the additional lines.

@rndmh3ro
Copy link
Member

Hey @MatthiasLohr, the problem here is that Centos6 and the others use OpenSSH 5.3 (or older) and the option "StreamLocalBindUnlink" does not exist in this version.

Can you replace it with something else, please?

Signed-off-by: Matthias Lohr <mail@mlohr.com>
@MatthiasLohr
Copy link
Contributor Author

@rndmh3ro, is the pull request now ok for acceptance?

@rndmh3ro
Copy link
Member

From the looks of it, yes! I Just want top Test it myself. :)

@rndmh3ro rndmh3ro merged commit cff51e1 into dev-sec:master Nov 18, 2018
@rndmh3ro
Copy link
Member

Thank you, Matthias!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants