Refactor: combine multiple set_fact into single jinja filter #846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyblargon
force-pushed
the
reduce-set-fact
branch
from
abb0b3f to
fd41b3c
Compare
Signed-off-by: Tinyblargon <76069640+Tinyblargon@users.noreply.github.com>
schurzi
force-pushed
the
reduce-set-fact
branch
from
fd41b3c to
85415e7
Compare
|
nice one, thank you @Tinyblargon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced 3 set_fact blocks with a single jinja filter, reducing the amount of redundant tasks to be displayed.
We can directly use the transformed result and don't have to mutate
sysctl_configas it's only used once.default({})creates an empty dict, ommiting the{}would result in the wrong type.