feat: Phase 0 Week 1 - Source Span Tracking (LSP Foundation) #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase 0, Week 1) - Created span.rs module with Position and Span structs - Position tracks line, column, and byte offset - Span tracks start/end positions with merge() support - 31 comprehensive unit tests with 100% coverage - Enhanced AST with span support - Added span() accessor methods to Stmt and Expr - Re-exported Span from ast module for backward compatibility - All AST nodes now expose their source locations - Updated parser infrastructure - Added span_from() helper for multi-token constructs - Parser tracks line/column positions from lexer - Note: Byte offset tracking deferred as enhancement - Added integration tests - 5 new tests verify span tracking on functions, expressions - Test span merge functionality and accessors - Total: 883 tests passing across workspace (568 compiler, 110 runtime, 38 test_harness, etc.) - Updated type_checker to use new span API - Changed span.line/span.column to span.line()/span.column() - All 568 compiler tests pass with new span implementation This implements tasks 1-4 from v0.0.5 Phase 0 Week 1: - ✅ Define Span and Position structs - ✅ Add span field to all AST nodes - ✅ Update parser to track spans from tokens - ✅ Update tests with span assertions Related to #v0.0.5, LSP foundation work
- Mark tasks 1-4 as completed (span tracking implementation) - Add implementation notes about byte offset deferral and point spans - Document backward compatibility approach with ast::Span re-export - Note Inspector fix (task 5) remains pending in separate PR
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Overview
Implements source span tracking for LSP foundation work as part of v0.0.5 Phase 0, Week 1.
Completes tasks 1-4 from the v0.0.5 planning document. Task 5 (Inspector property fix) will be addressed in a separate PR.
✅ Changes
Core Implementation
AST Updates
Parser Infrastructure
Type Checker Migration
Testing
Deferred Enhancements