Update .envrc, fix security warning #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roberto Di Remigio <roberto.diremigio@gmail.com>
robertodr
force-pushed
the
security-warning
branch
from
9cf749f to
f25fb9a
Compare
|
Tests are failing and it is not clear to me yet why. |
Signed-off-by: Roberto Di Remigio <roberto.diremigio@gmail.com>
robertodr
force-pushed
the
security-warning
branch
from
bb073d4 to
9db9579
Compare
|
Now green 🍏 🐙 |
TheErk
approved these changes
Nov 14, 2018
There was a problem hiding this comment.
Looks good to me.
Here is a SO reference: https://stackoverflow.com/questions/48680012/force-pipenv-to-create-a-new-virtualenv
In order to have a doc reminder/pointer on this.
|
Thank you for the fix! |
hjmjohnson
pushed a commit
to hjmjohnson/cmake-cookbook
that referenced
this pull request
Feb 23, 2020
Update .envrc, fix security warning Signed-off-by: Hans Johnson <hans.j.johnson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Does what is says on the tin. The security warning is the one issued by GitHub relating to the
requestsPython library.Status