This repository was archived by the owner on Oct 9, 2025. It is now read-only.
build: add progress spinner to command registration#156
Merged
Conversation
The changes in this commit add a progress spinner to the command registration process in the `deploy-commands.js` script. This is done to provide a more user-friendly experience while the commands are being registered, as the registration process can take some time, especially for a large number of commands. The key changes include: - Introducing a `startSpinner` function that displays a spinning progress indicator with the total number of commands being registered. - Clearing the spinner line and printing a "Done!" message when the registration is complete. - Handling the case where the build is not yet completed by throwing an error instead of exiting the process. These changes improve the overall user experience and provide better visual feedback during the command registration process.
dev-737
changed the title
|
dev-737
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this commit add a progress spinner to the command registration process in the
deploy-commands.jsscript. This is done to provide a more user-friendly experience while the commands are being registered, as the registration process can take some time, especially for a large number of commands.The key changes include:
startSpinnerfunction that displays a spinning progress indicator with the total number of commands being registered.These changes improve the overall user experience and provide better visual feedback during the command registration process.