Skip to content

Add directory exports module suffix #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Add directory exports module suffix #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8b5af1
[ethers-v5] Add node16 moduleSuffix to directories
chmanie Jun 21, 2023
773f4b9
[ethers-v5] Add changeset for directory moduleSuffix change
chmanie Jun 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/lazy-eggs-brush.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'typechain': patch
---

Add the node16 moduleSuffix also to directories (including the `index` filename) as in ESM directory root files have to
be explicitly stated (including their file extension).
2 changes: 1 addition & 1 deletion examples/ethers-v5-nodenext/types/ethers-contracts/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
/* tslint:disable */
/* eslint-disable */
export type { Dai } from "./Dai.js";
export * as factories from "./factories";
export * as factories from "./factories/index.js";
export { Dai__factory } from "./factories/Dai__factory.js";
3 changes: 3 additions & 0 deletions packages/typechain/src/codegen/createBarrelFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ export function createBarrelFiles(
`export type { ${namespaceIdentifier} };`,
].join('\n')

if (moduleSuffix) {
return `export * as ${namespaceIdentifier} from './${p}/index${moduleSuffix}';`
}
return `export * as ${namespaceIdentifier} from './${p}';`
})
.join('\n')
Expand Down