-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set the defaults for shared_fs mount in genai correctly #9433
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9433 +/- ##
==========================================
- Coverage 51.24% 48.61% -2.64%
==========================================
Files 746 1233 +487
Lines 110663 158973 +48310
Branches 2778 2778
==========================================
+ Hits 56712 77278 +20566
- Misses 53777 81521 +27744
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. just noting that adding the default to the cli arg could have side-effects in terms of not being able to tell if the user has provided it or not which matters at least for some of the other arguments
(cherry picked from commit 00bbda6)
Ticket
Description
We were not setting the default for the shared_fs mount dir correctly in
det deploy aws --deployment-type genai
Test Plan
Deploy a cluster with genai:
The master node should have no errors in the efs build in
/var/log/cloud-init-output.log
nor when mounting to the docker containerChecklist
docs/release-notes/
.See Release Note for details.