Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build react is not building ee mode #9209

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

eecsliu
Copy link
Contributor

@eecsliu eecsliu commented Apr 19, 2024

Ticket

Description

build react on e2e should be running ee mode and it previously wasn't. (test e2e should always run ee versions of determined)

Test Plan

Check the build-react job in test-e2e and make sure it builds the enterprise edition.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@eecsliu eecsliu requested a review from a team as a code owner April 19, 2024 20:56
@eecsliu eecsliu requested a review from molinamelendezj April 19, 2024 20:56
@cla-bot cla-bot bot added the cla-signed label Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d8c2695
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6622da6336d7030008c7db10

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.14%. Comparing base (b874acb) to head (d8c2695).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9209      +/-   ##
==========================================
- Coverage   44.75%   41.14%   -3.61%     
==========================================
  Files        1266     1128     -138     
  Lines      154655   143601   -11054     
  Branches     2438     2438              
==========================================
- Hits        69217    59090   -10127     
+ Misses      85206    84279     -927     
  Partials      232      232              
Flag Coverage Δ
harness 53.50% <ø> (-10.67%) ⬇️
web 35.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 202 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants