Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix how we are calling the bert embedding example #7851

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: fix how we are calling the bert embedding example #7851

merged 1 commit into from
Sep 12, 2023

Conversation

tayritenour
Copy link
Contributor

Description

This fixes one of the e2e_test examples that didn't get updated properly with the #7592 PR.

Test Plan

CI passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Sep 11, 2023
@netlify
Copy link

netlify bot commented Sep 11, 2023 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4a1e29a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/64ff51c41bbd52000871edb6

@wes-turner wes-turner self-requested a review September 11, 2023 17:48
wes-turner
wes-turner reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@wes-turner wes-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tayritenour tayritenour merged commit 5e04699 into main Sep 12, 2023
@tayritenour tayritenour deleted the fix_torch_batch_test branch September 12, 2023 16:29
hamidzr pushed a commit that referenced this pull request Sep 18, 2023
@tayritenour
fix: fix how we are calling the bert embedding example (#7851)
2f58e07
@dannysauer dannysauer added this to the 0.26.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wes-turner wes-turner wes-turner left review comments

@julian-determined-ai julian-determined-ai julian-determined-ai approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.
4 participants
@tayritenour @wes-turner @julian-determined-ai @dannysauer