feat: Support "cancelled" and "failed" Shutdown operations [MLG-468] #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayritenour
added
User-facing API Change
python
tayritenour
requested review from
mpkouznetsov,
garrett361 and
rb-determined-ai
tayritenour
changed the title
tayritenour
changed the title
Comment on lines
168
to
169
| // Deprecated: But maintained here for backwards compatibility | ||
| int32 placeholder = 1; |
There was a problem hiding this comment.
It's an internal API, so I vote to just break it. Also the comment above this line.
There was a problem hiding this comment.
i would agree to remove this.
There was a problem hiding this comment.
Makes sense, testing the changes to remove this
rb-determined-ai
approved these changes
Apr 25, 2023
tayritenour
force-pushed
the
MLG-468
branch
3 times, most recently
from
5789ace to
7b37726
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MLG-468
Supports sending Shutdown operations that are "cancelled" or "failed". This allows us on the python harness side to send operations like
searcher.Shutdown(failure=True)inside of a Custom SearcherSearchMethodto signal to the master that an experiment should be considered failed.Before, we made the assumption that any failures by individual trials in Custom Searches were all equally valid. However in use cases like the Deepspeed Autotuning project, we have special trials that cannot fail or the whole job should be stopped and considered failed. This change would allow the user to control that.
Test Plan
Here is a minimal example of a Custom Searcher that can simulate the new functionality:
test_shutdown.zip
To run, try both:
det experiment create dummy_searcher/no_fail.yaml .and
det experiment create dummy_searcher/fail.yaml .Each Custom Searcher should create two experiments, one being the orchestrator of the other agent experiment, which actually runs the prospective trials. The orchestrator will schedule a single trial, and on close, choose to
Shutdownthe agent experiment with a failure state or not depending on the yaml. Only the agent experiment should be notated as "failed".Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket