Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil deref in usage of incomplete experiment config policies #10068

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: nil deref in usage of incomplete experiment config policies #10068

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions master/internal/configpolicy/task_config_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,8 @@ func findAllowedPriority(scope *int, workloadType string) (limit int, exists boo
if err != nil {
return 0, false, fmt.Errorf("unable to unmarshal task config policies: %w", err)
}
if configs.Resources().Priority() != nil {
adminPriority := *configs.Resources().Priority()
if configs.RawResources != nil && configs.RawResources.RawPriority != nil {
adminPriority := *configs.RawResources.RawPriority
return adminPriority, false,
fmt.Errorf("priority set by invariant config: %w", errPriorityImmutable)
}
Expand Down
Loading