fix: Workspace Projects and Tasks test flakes [CM-554] #10026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10026 +/- ##
==========================================
- Coverage 54.60% 50.56% -4.04%
==========================================
Files 1259 949 -310
Lines 157329 128685 -28644
Branches 3621 3620 -1
==========================================
- Hits 85902 65066 -20836
+ Misses 71294 63486 -7808
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
reviewed
Oct 7, 2024
| const workspaceIds: number[] = []; | ||
|
|
||
| test.beforeAll(async ({ backgroundApiProject, backgroundApiWorkspace }) => { | ||
| // create workspace to use for List tests instead of using fixture: |
There was a problem hiding this comment.
tell me why inside this comment
JComins000
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
CM-554
Description
Potential fixes for flaky tests
Workspace Tasks › JupyterLab
Project List › Filter
Test Plan
No additional release party testing required. Automated tests should pass.
Checklist
docs/release-notes/See Release Note for details.