chore: check config policies on 'det notebook set priority' (#10047)

master/internal/command/command.go

@@ -12,6 +12,7 @@ import (
 	"github.com/uptrace/bun"
 	"golang.org/x/exp/slices"
 
+	"github.com/determined-ai/determined/master/internal/configpolicy"
 	internaldb "github.com/determined-ai/determined/master/internal/db"
 	"github.com/determined-ai/determined/master/internal/job/jobservice"
 	"github.com/determined-ai/determined/master/internal/rm"
@@ -278,6 +279,16 @@ func (c *Command) garbageCollect() {
 }
 
 func (c *Command) setNTSCPriority(priority int, forward bool) error {
+	if smallerHigher, err := c.rm.SmallerValueIsHigherPriority(); err == nil {
+		ok, err := configpolicy.PriorityUpdateAllowed(int(c.Metadata.WorkspaceID), model.NTSCType, priority, smallerHigher)
+		if err != nil {
+			return err
+		}
+		if !ok {
+			return fmt.Errorf("priority exceeds task config policy's priority_limit")
+		}
+	}
+
 	if forward {
 		switch err := c.rm.SetGroupPriority(sproto.SetGroupPriority{
 			Priority:     priority,

master/internal/command/command_intg_test.go

@@ -186,6 +186,7 @@ func setupTest(t *testing.T) *db.PgDB {
 	mockRM.On("Allocate", mock.Anything, mock.Anything).Return(sub, nil)
 	mockRM.On("Release", mock.Anything, mock.Anything).Return(nil)
 	mockRM.On("SetGroupPriority", mock.Anything, mock.Anything).Return(nil)
+	mockRM.On("SmallerValueIsHigherPriority").Return(true, nil)
 
 	cs, _ := NewService(db.SingleDB(), &mockRM)
 	SetDefaultService(cs)