Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple property assignments in KTS #6251

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Simple property assignments in KTS #6251

merged 2 commits into from
Jul 14, 2023

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Jul 3, 2023

@detekt-ci detekt-ci added the build label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #6251 (b93ca64) into main (7383f45) will decrease coverage by 0.74%.
The diff coverage is n/a.

❗ Current head b93ca64 differs from pull request most recent head 8c65057. Consider uploading reports for the commit 8c65057 to get more accurate results

@@             Coverage Diff              @@
##               main    #6251      +/-   ##
============================================
- Coverage     85.19%   84.45%   -0.74%     
+ Complexity     4029     4001      -28     
============================================
  Files           568      568              
  Lines         13421    13440      +19     
  Branches       2376     2378       +2     
============================================
- Hits          11434    11351      -83     
- Misses          829      934     +105     
+ Partials       1158     1155       -3

see 21 files with indirect coverage changes

@3flex
Copy link
Member

3flex commented Jul 3, 2023

Thanks! I'd thought about doing this but it's incubating so I found it a bit distracting in the IDE. My personal preference is to wait for 8.3 when Gradle plans to make it stable but I don't want to block it if others see the value.

@3flex 3flex added the housekeeping Marker for housekeeping tasks and refactorings label Jul 4, 2023
@Goooler
Merge branch 'main' into kts_assign
8c65057 
# Conflicts:
#	build-logic/src/main/kotlin/module.gradle.kts
#	detekt-gradle-plugin/build.gradle.kts
@Goooler Goooler mentioned this pull request Jul 12, 2023
Merged
9 tasks
@cortinico cortinico added this to the 2.0.0 milestone Jul 14, 2023
@cortinico cortinico merged commit 60c73fb into detekt:main Jul 14, 2023
@Goooler Goooler deleted the kts_assign branch July 14, 2023 00:29
mgroth0 pushed a commit to mgroth0/detekt that referenced this pull request Feb 11, 2024
@Goooler @mgroth0
Simple property assignments in KTS (detekt#6251)
cf21572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

@BraisGabin BraisGabin BraisGabin approved these changes

Assignees
No one assigned
Labels
build housekeeping Marker for housekeeping tasks and refactorings
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Goooler @3flex @BraisGabin @cortinico @detekt-ci