Skip to content

Comments

[pull] master from kyb3r:master#13

Open
pull[bot] wants to merge 16 commits intodetection:masterfrom
modmail-dev:master
Open

[pull] master from kyb3r:master#13
pull[bot] wants to merge 16 commits intodetection:masterfrom
modmail-dev:master

Conversation

@pull
Copy link

@pull pull bot commented Dec 19, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added the ⤵️ pull label Dec 19, 2022
Jamie and others added 15 commits July 16, 2023 03:49
Signed-off-by: Jamie <jamie@sootmc.net>
Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
* updating the discord server and github url

was still pointing to the dead discord server. 

Signed-off-by: EP <maidos88@gmail.com>

* Use the same inv link as the modmail repo

---------

Signed-off-by: EP <maidos88@gmail.com>
Co-authored-by: Taku <45324516+Taaku18@users.noreply.github.com>
Signed-off-by: Taku <45324516+Taaku18@users.noreply.github.com>
Avatar images have an onerror attribute to set their image to a generic avatar image if they fail to load from discord. However, in situations where the network fails or the discord CDN is unavailable for some reason (adblockers), this will throw an error as well.

In browsers other than chrome, this will trigger the on-error handler again, infinitely looping requests as fast as possible. 

We set the onerror handler to null before making the new request to get around this and ensure if the fallback fails to load we don't make further requests.

Signed-off-by: Bast <52266665+bast0006@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants