fix: Fix ui.Slider.New() to accept a type for min and max
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ui.Spinbox.New()` defines a `TypeEnum` containing an `Integer` struct for representing the min and max values. This was missing from `ui.Slider.New()`, which accepted the values as individual arguments. Since precisely the same concept of min and max applies to both a slider and a spinbox, their API should be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting the control gallery example (#14) I ran into an issue with
ui.Slider.New().ui.Spinbox.New()defines aTypeEnumcontaining anIntegerstruct for representing the min and max values. This was missing fromui.Slider.New(), which accepted the values as individual arguments.This stood out when the two controls were used side by side in the example code.
Since precisely the same concept of min and max applies to both a slider and a spinbox, their API should be consistent.