Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timestamp support to youtube embeds #312

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Add timestamp support to youtube embeds #312

merged 4 commits into from
Sep 1, 2023

Conversation

Riott
Copy link
Contributor

@Riott Riott commented Aug 31, 2023

This adds timestamp support in the hash link converter so that we can embed youtube links with the right timestamp.

11k
11k requested changes Aug 31, 2023
View reviewed changes
assets/chat/js/hashlinkconverter.js Outdated Show resolved Hide resolved
assets/chat/js/hashlinkconverter.js Outdated Show resolved Hide resolved
@Riott Riott requested a review from 11k August 31, 2023 18:55
11k
11k approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into whether we need to escape the hash URL after converting, but it seems URL takes care of that. When accessing components of the parsed URL using its API, they're already escaped.

@11k 11k merged commit a95f1c8 into destinygg:master Sep 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@11k 11k 11k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Riott @11k