fix: dont embed kick vods and clips (#315)

destinygg · Sep 6, 2023 · 6b8b2d2 · 6b8b2d2
1 parent fcec616
commit 6b8b2d2
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/assets/chat/js/chat.js b/assets/chat/js/chat.js
@@ -1854,7 +1854,7 @@ class Chat {
     } catch (error) {
       MessageBuilder.error(error.message).into(this);
       MessageBuilder.info(
-        'Usage: /embed <link> OR /e <link> (Valid links: Twitch streams, VODs, clips, Youtube, Rumble)',
+        'Usage: /embed <link> OR /e <link> (Valid links: Twitch streams, VODs, clips, Youtube, Rumble, Kick streams)',
       ).into(this);
     }
   }
@@ -1878,7 +1878,7 @@ class Chat {
           MessageBuilder.error(error.message).into(this);
         }
         MessageBuilder.info(
-          'Usage: /postembed [<link>] [<message>] (Alias: /pe) (Valid links: Twitch streams, VODs, clips, Youtube, Rumble)',
+          'Usage: /postembed [<link>] [<message>] (Alias: /pe) (Valid links: Twitch streams, VODs, clips, Youtube, Rumble, Kick streams)',
         ).into(this);
       }
     }

diff --git a/assets/chat/js/hashlinkconverter.js b/assets/chat/js/hashlinkconverter.js
@@ -73,6 +73,9 @@ class HashLinkConverter {
         throw new Error(RUMBLE_EMBED_ERROR);
       case 'www.kick.com':
       case 'kick.com':
+        if (url.searchParams.has('clip') || pathname.startsWith('video/')) {
+          throw new Error(INVALID_LINK_ERROR);
+        }
         return `#kick/${pathname}`;
       default:
         throw new Error(INVALID_LINK_ERROR);

diff --git a/assets/chat/js/hashlinkconverter.test.js b/assets/chat/js/hashlinkconverter.test.js
@@ -64,6 +64,7 @@ describe('Valid embeds', () => {
       'https://rumble.com/embed/v26pcdc/?pub=4',
       '#rumble/v26pcdc',
     ],
+    ['Kick stream link', 'https://kick.com/destiny', '#kick/destiny'],
   ])('%s', (_, url, expectedHashLink) => {
     const hlc = new HashLinkConverter();
     expect(hlc.convert(url)).toBe(expectedHashLink);
@@ -83,6 +84,16 @@ describe('Invalid embeds', () => {
       'https://www.youtube.com/tZ_gn0E87Qo',
       MISSING_VIDEO_ID_ERROR,
     ],
+    [
+      'Kick VOD link',
+      'https://kick.com/video/d353657d-f6c5-40c0-9df2-645aadda1e66',
+      INVALID_LINK_ERROR,
+    ],
+    [
+      'Kick clip link',
+      'https://kick.com/destiny?clip=clip_01H96SPCHRV0E2X8Y670CGXTS4',
+      INVALID_LINK_ERROR,
+    ],
     [
       'No arguments were giving after the command',
       undefined,