Skip to content

Commit

Permalink
fix: set initial browser action popup height in Safari
Browse files Browse the repository at this point in the history
  • Loading branch information
dessant committed Nov 6, 2023
1 parent 21fbee7 commit f738727
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
15 changes: 13 additions & 2 deletions src/action/App.vue
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,11 @@ body {
max-height: 100px;
padding-top: 8px;
padding-bottom: 24px;
transition: max-height 0.3s ease, padding-top 0.3s ease,
padding-bottom 0.3s ease, opacity 0.2s ease;
transition:
max-height 0.3s ease,
padding-top 0.3s ease,
padding-bottom 0.3s ease,
opacity 0.2s ease;
}
.settings-enter-from,
Expand Down Expand Up @@ -758,4 +761,12 @@ html.samsung {
height: initial;
}
}
// Safari 17: the popover opens after a delay the first time the action
// button is clicked on macOS 14, unless the height is declared.
@if $target-env == 'safari' {
html {
min-height: 56px;
}
}
</style>
6 changes: 6 additions & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,12 @@ module.exports = {
sassOptions: {
includePaths: ['node_modules'],
quietDeps: true
},
additionalData: (content, loaderContext) => {
return `
$target-env: "${targetEnv}";
${content}
`;
}
}
}
Expand Down

0 comments on commit f738727

Please sign in to comment.