Haptic and audible feedback on emoji key press + key border displayed properly. #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sslater11
changed the title
dessalines
approved these changes
Sep 20, 2023
|
In the future you have to put |
|
That's a good suggestion, thank you. I will put the "Fixes #issuenum" in the git commit next time 😄. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #421 and #422
I just copied and pasted your code for the audible and haptic feedback that already existed.
Issue:
If we enable/disable the audible or haptic feedback whilst the emoji picker is open, the effects won't take place. We have to switch out of the emoji picker and back into it for the changes to take effect.
I'm not really sure how to fix that as I don't see how you've achieved it.
The key borders in emoji view were displayed incorrectly, and now they show as white in dark mode and black in light mode.