Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single quote to MessageEase German #323

Merged

Conversation

meliache
Copy link
Contributor

In MessageEase, the single quote is in the same position in the German layout as in the English layout.

In Thumbkey however, it was missing from the German layout.

I just copied over the relevant part of the keymap from the MessageEaseEn.kt file.

I don't have an Android development setup and therefore could not run or test the code, but since it's just some copy-paste I could do that in a simple text editor. But in case of doubts, please test that it works.

In MessageEase, the single quote is in the same position in the German layout as
in the English layout. In Thumbkey however, it was missing from the German
layout.

I just copied over the relevant part of the keymap from the ME English keymap.
@meliache
Copy link
Contributor Author

meliache commented Jul 24, 2023

One note, the previous MessageEaseDe.kt layout has the single quote in the symbol layer, just not in the default layer, which differs from actual MessageEase, where it is shown before even swiping up on the space bar (see screenshot above).

The Woodpecker CI seems to have failed due to a timeout when cloning the original repo, but to me this seems like the CI just needs to be rerun.

@dessalines dessalines enabled auto-merge (squash) July 25, 2023 21:39
@dessalines dessalines merged commit 345e643 into dessalines:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants