-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed layouts indexes in Types.kt #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! While working on a Hebrew layout I noticed that the only change you need to make in this file is changing the index of the ThumbKeyFIv1Wide
layout to 22. This is due to this commit which adds the layout but not assigns a new index: 2e76ba4
@roihershberg, the problem was in the 18th index (suomi wide & ru with symbols were the same), so I added +1 to every layout created by me) |
@roihershberg, yeah, now I see. I've looked at the changes and u're right) |
I think that the problem when messing with the indexes is that it will change the chosen layouts in the settings. I haven't looked at the code but I'm almost certain that the chosen layouts are stored in the shared preferences by their index. That's how I discovered this bug. Try a version of this app before your changes, choose the layouts that you've changed the index for and then install the version of the app with your changes and see if you now have different layouts or a different order of the layouts. |
@Chirikumbrah @dessalines patch-effect-on-layouts.mp4 |
Could you do a PR to fix this? |
Yes |
No layouts should have changed indices as of the 1.0.0 release. |
Now all layouts should be displayed correctly :)