feat: add four-way and two-way swipes #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional parameter to limit swipes to only four or two directions which increases detection range for those directions. This should improve typing accuracy by reducing accidental center-key activation.
dessalines
requested changes
May 8, 2023
Applied automatic format fixes. Removed unnecessary exception. Rename FOUR_WAY -> FOUR_WAY_CROSS. Refs: dessalines#214
mpice-mn
added a commit
to mpice-mn/thumb-key
that referenced
this pull request
Sep 23, 2023
* feat: add four-way and two-way swipes Add optional parameter to limit swipes to only four or two directions which increases detection range for those directions. This should improve typing accuracy by reducing accidental center-key activation. * refactor: code cleanup for PR dessalines#214 Applied automatic format fixes. Removed unnecessary exception. Rename FOUR_WAY -> FOUR_WAY_CROSS. Refs: dessalines#214 --------- Co-authored-by: mpice-mn <noreply@domain.tld>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional parameter to limit swipes to only four or two directions which increases detection range for those directions (90 degrees on 4-way, 180 on 2-way, vs. 45 degrees with the previous 8-way behavior). This should improve typing accuracy by reducing accidental center-key activation.
Only used on common keys for now (backspace, space, numeric layout switcher).
If this PR gets accepted I can apply it to the normal keybaord layouts later where appropriate.