Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #7 and #8 resolved successfully #9

Closed
wants to merge 1 commit into from
Closed

Issue #7 and #8 resolved successfully #9

wants to merge 1 commit into from

Conversation

Sofiyan-coder
Copy link
Contributor

@Sofiyan-coder Sofiyan-coder commented Sep 12, 2024

Fixes #7 and #8

Description
Changed Integer to Long and INT to BIGINT

Screenshots

Copy link
Contributor

deepsource-io bot commented Sep 12, 2024

Here's the code health analysis summary for commits 1805ef7..f6c545e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Java LogoJava✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nmarulo
Copy link
Member

nmarulo commented Sep 12, 2024

Hi @Sofiyan-coder,

Thank you very much for your interest in contributing to this project.

I'm sorry but, I can't accept a PR with:
image
of affected lines, the issues are not enough for so many changes. Please limit commits to the corresponding files and exclude any changes not related to the issue.

Also reviewing the changes, you have not modified all the files, that is, if you try to compile, the compilation will fail. It will fail as I commented in the issues, because you have to modify the files that you indicate in the images that I attached in each issue.

I don't know if you have already read issue #2, if you haven't, please read it. Thank you.

I don't know if you will be participating in the hacktoberfest, but remember it starts on October 1st. I can assign you one when this day arrives. Or if you didn't know about this event, in that case, sorry, the issues marked with this hacktoberfest label are only for this event.

@nmarulo nmarulo closed this Sep 12, 2024
@Sofiyan-coder
Copy link
Contributor Author

Hi @nmarulo
Ok, I was not aware of Hacktoberfest before, but I know now I will participate in the Event. after Sept 23
and hope you will assign me this issue to me in the future and will contribute a Quality PR/MR
thank you for information and help in starting my Open-source career

@nmarulo
Copy link
Member

nmarulo commented Sep 13, 2024

@Sofiyan-coder Ok, I'm glad you are interested in the Event.

A little TIP, in case you are interested. When you make “Pull Request” in repositories, the key is “less is more”, this means that: Only add to the commit the changes related to the PR, don't make more than one issue on the same PR, avoid refactoring the code (instead create an issue commenting that refactoring), remember to read the contribution guidelines of each repository. All this is basically to make your PR easy to review, which greatly increases the chances that it will be accepted quickly.

This project is open to feedback. Although the issues I have created are all for the hacktoberfest, anyone is free to create more issues, I will gladly consider them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update type in Product database
2 participants