Conversation
Owner
Author
|
히익 오류발견 아이폰6s에서 이미지가 사라졌다! - 수정할게요.. |
MMMIIIN
reviewed
Aug 11, 2022
MMMIIIN
left a comment
MMMIIIN
left a comment
There was a problem hiding this comment.
감사합니다 ! 친구에게 많은 도움이 될 것 같네요 ^______^
| .padding() | ||
| .background(type.color) | ||
| .clipShape(Capsule()) | ||
| .overlay(Capsule().stroke(Color.white, lineWidth: 0.3)) |
There was a problem hiding this comment.
p3;
signup 버튼에는 흰 테두리가 없는데 이건 조건처리가 안된걸까요 ??
Owner
Author
There was a problem hiding this comment.
어머 이런 디테일까지는 발견하지 못했네요 ^___^ 수정할게요!
Comment on lines
+11
to
+16
| let buttonHorizontalPadding = 32.0 | ||
| let mainLogoSize = 44.0 | ||
| let signupButtonInterval = 10.0 | ||
| let loginButtonPadding = 28.0 | ||
| let titleInterval = 28.0 | ||
| let titleAndButtonInterval = 40.0 |
There was a problem hiding this comment.
Suggested change
| let buttonHorizontalPadding = 32.0 | |
| let mainLogoSize = 44.0 | |
| let signupButtonInterval = 10.0 | |
| let loginButtonPadding = 28.0 | |
| let titleInterval = 28.0 | |
| let titleAndButtonInterval = 40.0 | |
| private enum Size { | |
| static let buttonHorizontalPadding = 32.0 | |
| static let mainLogoSize = 44.0 | |
| static let signupButtonInterval = 10.0 | |
| static let loginButtonPadding = 28.0 | |
| static let titleInterval = 28.0 | |
| static let titleAndButtonInterval = 40.0 | |
| } |
공통으로 관리되지 않는 nameSpace라면 위와같은 방법은 어떨까요 ??
nameSpace에 대해 관련 글 첨부합니다 한번 참고해보세용 ! ^______^
| .padding(.vertical, loginButtonPadding) | ||
| } | ||
|
|
||
| private func title() -> some View { |
There was a problem hiding this comment.
p4;
title이란 네이밍이 조금은 모호할 수 있을 것 같아요 !
Text만 담고 있을 것 같았는데 아이콘 이미지까지 같이 있으니 헷갈리네요 !
내부 View들을 분리하거나, 다른 네이밍은 어떨까요 ??
조심스럽게 제안해봅니다..
Owner
Author
하나둘셋 케미친구 화이팅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ 작업 내용
✨ PR 포인트
✨ 기타
Swiftui 오랜만에 하니까 꿀잼. 재밌는 숙제 케미 감사링 다음숙제 기다리겠음