Parse auth errors for HTTP repos

desktop · May 13, 2024 · 29b23b4 · 29b23b4
1 parent 6915785
commit 29b23b4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/errors.ts b/lib/errors.ts
@@ -69,7 +69,7 @@ export const GitErrorRegexes: { [regexp: string]: GitError } = {
     GitError.BadConfigValue,
   'ERROR: ([\\s\\S]+?)\\n+\\[EPOLICYKEYAGE\\]\\n+fatal: Could not read from remote repository.':
     GitError.SSHKeyAuditUnverified,
-  "fatal: Authentication failed for 'https://":
+  "fatal: Authentication failed for 'https?://":
     GitError.HTTPSAuthenticationFailed,
   'fatal: Authentication failed': GitError.SSHAuthenticationFailed,
   'fatal: Could not read from remote repository.': GitError.SSHPermissionDenied,

diff --git a/test/fast/git-process-test.ts b/test/fast/git-process-test.ts
@@ -287,7 +287,21 @@ describe('git-process', () => {
       expect((error as any).code).toBe(RepositoryDoesNotExistErrorCode)
     })
 
-    it('can parse errors', () => {
+    it('can parse HTTPS auth errors', () => {
+      const error = GitProcess.parseError(
+        "fatal: Authentication failed for 'https://www.github.com/shiftkey/desktop.git/'"
+      )
+      expect(error).toBe(GitError.HTTPSAuthenticationFailed)
+    })
+
+    it('can parse HTTP auth errors', () => {
+      const error = GitProcess.parseError(
+        "fatal: Authentication failed for 'http://localhost:3000'"
+      )
+      expect(error).toBe(GitError.HTTPSAuthenticationFailed)
+    })
+
+    it('can parse SSH auth errors', () => {
       const error = GitProcess.parseError('fatal: Authentication failed')
       expect(error).toBe(GitError.SSHAuthenticationFailed)
     })